This corrects the logic for turning off flag 4G if a user with level 99 answers 'no' to the 'Ask again later' question about creating a Guest/Anonymous user account.

224c224
< user.security.flags4&=~UFLAG_G; /* Turn off flag 4G to not ask again */
---

user.security.flags4&=!~UFLAG_G; /* Turn off flag 4G to

not ask again */



echto
---
■ Synchronet ■ -=-= echto bbs =-=-

Re: logon.js.patch
By: echto to Digital Man on Sun Nov 13 2011 02:08 pm

This corrects the logic for turning off flag 4G if a user with level 99 answers 'no' to the 'Ask again later' question about creating a Guest/Anonymous user account.

224c224
< user.security.flags4&=~UFLAG_G; /* Turn off flag 4G to not ask again */

Um, no it doesn't. It's a bit-flag, not a boolean.

digital man

Synchronet "Real Fact" #29:
The COM I/O routines for Synchronet for DOS were written in ASM by Steve Deppe.

Re: logon.js.patch
By: Digital Man to echto on Sun Nov 13 2011 19:57:43

Um, no it doesn't. It's a bit-flag, not a boolean.

Hmm.. ok. I kept getting prompted even after answering "no" so I added that and it correctly set the flag. You might want to try and duplicate it on your end.

echto
bbs.echto.net


---
■ Synchronet ■ -=-= echto bbs =-=-

Re: logon.js.patch
By: Digital Man to echto on Sun Nov 13 2011 19:57:43

< user.security.flags4&=~UFLAG_G; /* Turn off flag 4G to

Ok, I found your js object documentation. For some reason the bit is not being flipped with the above statement.

echto
bbs.echto.net


---
■ Synchronet ■ -=-= echto bbs =-=-

Re: logon.js.patch
By: Digital Man to echto on Sun Nov 13 2011 19:57:43

Um, no it doesn't. It's a bit-flag, not a boolean.

I may have tracked it down. Please take a look at sbbsdefs.js. Here is an excerpt. Start at line 777. Notice anything odd? scroll down and you will see this. " var U_FLAGS4 =U_FLAGS3+8; /* Flag set #4 */ "

/********************************************/
/* field values for system.matchuserdata() */ /********************************************/
var U_ALIAS =0;
var U_NAME =U_ALIAS+LEN_ALIAS;
var U_HANDLE =U_NAME+LEN_NAME;
var U_NOTE =U_HANDLE+LEN_HANDLE+2;
var U_COMP =U_NOTE+LEN_NOTE;
var U_COMMENT =U_COMP+LEN_COMP+2;
var U_NETMAIL =U_COMMENT+LEN_COMMENT+2;
var U_ADDRESS =U_NETMAIL+LEN_NETMAIL+2;
var U_LOCATION =U_ADDRESS+LEN_ADDRESS;
var U_ZIPCODE =U_LOCATION+LEN_LOCATION;
var U_PASS =U_ZIPCODE+LEN_ZIPCODE+2;
var U_PHONE =U_PASS+8;
var U_BIRTH =U_PHONE+12;
var U_MODEM =U_BIRTH+8;
var U_LASTON =U_MODEM+8;
var U_FIRSTON =U_LASTON+8;
var U_EXPIRE =U_FIRSTON+8;
var U_PWMOD =U_EXPIRE+8;
var U_LOGONS =U_PWMOD+8+2;


echto
bbs.echto.net


---
■ Synchronet ■ -=-= echto bbs =-=-

Re: logon.js.patch
By: echto to Digital Man on Sun Nov 13 2011 10:34 pm

Re: logon.js.patch
By: Digital Man to echto on Sun Nov 13 2011 19:57:43

Um, no it doesn't. It's a bit-flag, not a boolean.

Hmm.. ok. I kept getting prompted even after answering "no" so I added
that and it correctly set the flag. You might want to try and duplicate it on your end.

Okay, I'll do that. It might be missing some parens.

digital man

Synchronet "Real Fact" #21:
The second ever Synchronet BBS was the Mid-Nite Hacker BBS (sysop: The Zapper).

Re: logon.js.patch - take a look at sbbsdefs.js please
By: echto to Digital Man on Mon Nov 14 2011 05:43 pm

Re: logon.js.patch
By: Digital Man to echto on Sun Nov 13 2011 19:57:43

Um, no it doesn't. It's a bit-flag, not a boolean.

I may have tracked it down. Please take a look at sbbsdefs.js. Here is an excerpt. Start at line 777. Notice anything odd? scroll down and you
will see this. " var U_FLAGS4 =U_FLAGS3+8; /* Flag set #4 */

It's not obvious to me what you think the problem is. These U_FLAG* macros (offsets into user.dat records) are not to be confused with the UFLAG_* macros (bit flag definitions). They're not used inter-changeably.

digital man

Synchronet "Real Fact" #79:
85 SBBSecho registrations were sold (at $49) between 1994 and 1996.

Re: logon.js.patch
By: Digital Man to echto on Wed Nov 16 2011 03:40 pm

Re: logon.js.patch
By: echto to Digital Man on Sun Nov 13 2011 10:34 pm

Re: logon.js.patch
By: Digital Man to echto on Sun Nov 13 2011 19:57:43

Um, no it doesn't. It's a bit-flag, not a boolean.

Hmm.. ok. I kept getting prompted even after answering "no" so I added that and it correctly set the flag. You might want to try and duplicate

it

on your end.

Okay, I'll do that. It might be missing some parens.

Just tested it here and it turned off the 4G flag for user #1 as expected.

digital man

Synchronet "Real Fact" #50:
Rob Swindell was introduced to BBSing in 1982 by his older brother, Dr. Seuss.

Re: logon.js.patch - take a look at sbbsdefs.js please
By: Digital Man to echto on Wed Nov 16 2011 15:46:46

It's not obvious to me what you think the problem is. These U_FLAG* macros

Ok, it just looks kind of odd to me; the 'field values for system.matchuserdata() section.

var U_ALIAS =0;
var U_NAME =U_ALIAS+LEN_ALIAS;
var U_HANDLE =U_NAME+LEN_NAME;
var U_NOTE =U_HANDLE+LEN_HANDLE+2;
var U_COMP =U_NOTE+LEN_NOTE;
var U_COMMENT =U_COMP+LEN_COMP+2;
var U_NETMAIL =U_COMMENT+LEN_COMMENT+2;
var U_ADDRESS =U_NETMAIL+LEN_NETMAIL+2;
var U_LOCATION =U_ADDRESS+LEN_ADDRESS;
var U_ZIPCODE =U_LOCATION+LEN_LOCATION;
var U_PASS =U_ZIPCODE+LEN_ZIPCODE+2;
var U_PHONE =U_PASS+8;
var U_BIRTH =U_PHONE+12;

/going psuedo here/
U_ALIAS = 0;
U_NAME = alias plus length
U_NEMAIL = comment + length of comment 2
U_PASS = zipcode
U_BIRTH = phone number

FIrst impression from looking at it and seeing BIRTH = PHONE kinda made me wonder if the 2 columns were pasted together incorrectly.

Thanks for taking a look.

echto

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
---===== [ telnet://bbs.echto.net 1:340/100 ] =====--- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

---
■ Synchronet ■ -=-= echto bbs =-=-

Re: logon.js.patch - take a look at sbbsdefs.js please
By: echto to Digital Man on Wed Nov 16 2011 17:49:21

Re: logon.js.patch - take a look at sbbsdefs.js please
By: Digital Man to echto on Wed Nov 16 2011 15:46:46

It's not obvious to me what you think the problem is. These U_FLAG* macro

Ok, it just looks kind of odd to me; the 'field values for system.matchuserdata() section.

var U_ALIAS =0;
var U_NAME =U_ALIAS+LEN_ALIAS;
var U_HANDLE =U_NAME+LEN_NAME;
var U_NOTE =U_HANDLE+LEN_HANDLE+2;
var U_COMP =U_NOTE+LEN_NOTE;
var U_COMMENT =U_COMP+LEN_COMP+2;
var U_NETMAIL =U_COMMENT+LEN_COMMENT+2;
var U_ADDRESS =U_NETMAIL+LEN_NETMAIL+2;
var U_LOCATION =U_ADDRESS+LEN_ADDRESS;
var U_ZIPCODE =U_LOCATION+LEN_LOCATION;
var U_PASS =U_ZIPCODE+LEN_ZIPCODE+2;
var U_PHONE =U_PASS+8;
var U_BIRTH =U_PHONE+12;

/going psuedo here/
U_ALIAS = 0;
U_NAME = alias plus length
U_NEMAIL = comment + length of comment 2
U_PASS = zipcode
U_BIRTH = phone number

FIrst impression from looking at it and seeing BIRTH = PHONE kinda made me wonder if the 2 columns were pasted together incorrectly.

that's generally my fault for even being there. those values are for use with system.matchuserdata() sine that method previous had no reference for the associated record offsets.






---
■ Synchronet ■ The BRoKEN BuBBLE (MDJ.ATH.CX)

Re: logon.js.patch - take a look at sbbsdefs.js please
By: echto to Digital Man on Wed Nov 16 2011 05:49 pm

FIrst impression from looking at it and seeing BIRTH = PHONE kinda made me wonder if the 2 columns were pasted together incorrectly.

They're correct.

Thanks for taking a look.

No problem.

digital man

Synchronet "Real Fact" #6:
The name "Synchronet" was suggested by Steve Deppe (Ille Homine Albe) in 1991.